ci: simpler release script #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Simplified the release process in scripts/make-release.sh by streamlining version management and changelog generation while improving safety through manual intervention requirements.
- Switched from git-cliff to cargo-cliff for more reliable changelog generation
- Removed automatic artifact building and SHA computation to reduce complexity
- Added clearer user guidance for manual git push operations
- Improved error handling with more descriptive messages
- Simplified version validation by relying on regex check only
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| # -- Step 1: Read current version from Cargo.toml -- | ||
| # 2. Get the current version from Cargo.toml | ||
| CURRENT_VERSION="$(cargo pkgid | cut -d# -f2 | cut -d: -f2)" |
Contributor
There was a problem hiding this comment.
logic: cargo pkgid output format could change in future Cargo versions. Consider adding error handling if cut commands fail.
| git-cliff --config cliff.toml --tag "v${NEW_VERSION}" --output CHANGELOG.md | ||
| # 4. Generate/Update CHANGELOG using cargo-cliff | ||
| # Make sure cargo-cliff is installed (cargo install cargo-cliff) | ||
| cargo cliff --tag "v${NEW_VERSION}" --output CHANGELOG.md |
Contributor
There was a problem hiding this comment.
logic: cargo cliff command will fail if not installed. Add check for cargo-cliff installation before using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.